botonic-react: remove getConfig function #BLT-1036 #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
changed the title
vanbasten17
approved these changes
Sep 16, 2024
MarcosCA
approved these changes
Sep 16, 2024
Iru89
force-pushed
the
BLT-1036-remove-botonic-get-config
branch
from
be12e94
to
4627692
Compare
Test Results30 tests ±0 26 ✅ ±0 33s ⏱️ -3s For more details on these failures, see this check. Results for commit 4627692. ± Comparison against base commit e08d09f. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the getConfig function that is run to get the response from the botonic-config lambda.
Context
In the new version of cli we will create the bot configuration at the moment of deploying, it will be saved in the database and will be updated in each deploy. We will not only have the plugins configuration.