#451 Added chocolatey package support for Functions. #564
Conversation
fn/chocolatey/functions.nuspec
Outdated
| <projectUrl>https://github.com/iron-io/functions/</projectUrl> | ||
| <!--<iconUrl>http://cdn.rawgit.com/__REPLACE_YOUR_REPO__/master/icons/functions.png</iconUrl>--> | ||
| <copyright>2017 Functions Iron.io</copyright> | ||
| <tags>serverless faas docker lambda</tags> |
There was a problem hiding this comment.
IFAIK we'd like to keep ourselves for being associated with Serverless (see https://serverless.com/). So it'll be better to have next tags:
functions faas docker containers (as an alternative - include COE there).
There was a problem hiding this comment.
I'd say keep serverless and add functions. We do want to be associated with the term serverless as that's what everyone is referring to it as for the time being.
There was a problem hiding this comment.
ok done. Kept serverless and added functions.
fn/chocolatey/functions.nuspec
Outdated
|
|
||
| <title>Iron.io Functions (Install)</title> | ||
| <authors>Iron.io Inc.</authors> | ||
| <projectUrl>https://github.com/iron-io/functions/</projectUrl> |
There was a problem hiding this comment.
trailing slash? just remove slash right after functions
There was a problem hiding this comment.
ok done. Removed both the trailing slash from the <projectUrl> and <packageSourceUrl>.
|
|
||
| $packageName= 'functions' | ||
| $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)" | ||
| $url = 'https://github.com/iron-io/functions/releases/download/0.2.25/fn.exe' |
There was a problem hiding this comment.
Could this URL always grab the latest release? Similar to install.sh ?
There was a problem hiding this comment.
Unfortunately this URL is bound to that version. We might need to adjust scripts to auto increase the version. Updated version to 0.2.36.
There was a problem hiding this comment.
Yes, we need to make the scripts update the version on release, same way as we do for git, docker, cli install, etc.
How does this get submitted to Chocolatey? We'll want to make sure that's automated too.
|
|
||
| $packageName= 'functions' | ||
| $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)" | ||
| $url = 'https://github.com/iron-io/functions/releases/download/0.2.25/fn.exe' |
There was a problem hiding this comment.
Yes, we need to make the scripts update the version on release, same way as we do for git, docker, cli install, etc.
How does this get submitted to Chocolatey? We'll want to make sure that's automated too.
* Fix lambda import * more updates * more changes
* Add inactivity_timeout to routes API Closes: iron-io#544 * Fix failing datastore tests * Rename inactivity_timeout to idle_timeout * Update swagger doc * Update hot fn doc * Fix json tags * Add function timeouts docs * Rewording
* Solving postgres marshal/unmarshal issue Postgres datastore was not marshaling the App config during its insert, that behavior was resulting in issues when fetching the App and the datastore couldn't unmarshal the config. The same issue was probably happening with the Route's headers in some situations. This commit's idea is to always try to marshal configs and headers when inserting/updating Apps or Routes. But in Apps and Routes get methods, if the config/headers unmarshal fails, it returns an empty config/headers. * fix one more unmarshal case * returning error when unmarshaling non-empty
|
|
martinpinto
force-pushed
the
fn_chocolatey
branch
from
a6fc90f
to
6aade2f
Compare
Added a new package for chocolatey for the latest Functions version.