Flatbuffers serialization, aggregation optimization, build improvements #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging enclave code
podcastinator
requested changes
Dec 2, 2020
server/host/host.cpp
Outdated
| @@ -14,22 +12,32 @@ using namespace std; | |||
| char* path = "./enclave/enclave.signed"; | |||
| uint32_t flags = OE_ENCLAVE_FLAG_DEBUG | OE_ENCLAVE_FLAG_SIMULATE; | |||
|
|
|||
| // Helper function used to copy double pointers from untrusted memory to enclave memory | |||
There was a problem hiding this comment.
This function is not being used.
podcastinator
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I did not include Flatbuffers installation and build as part of this PR. I opened #6 to note this. To install Flatbuffers you can do
snap install flatbuffers.Co-authored-by: David Yi < davidyi624@berkeley.edu>
Co-authored-by: Rishabh Poddar rishabhp89@gmail.com
Co-authored-by: Octavian Sima 34696537+octaviansima@users.noreply.github.com