Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data paths absolute in usage example #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make data paths absolute in usage example #152

wants to merge 2 commits into from

Conversation

chester-leung
Copy link
Member

Fixes #139

podcastinator
podcastinator reviewed May 6, 2021
View reviewed changes
Copy link
Member

@podcastinator podcastinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think determining the path to the data folder using getcwd or similar might be nicer?

@chester-leung
Copy link
Member Author

I think determining the path to the data folder using getcwd or similar might be nicer?

This update is just for the example in the README - the point is that the user should specify an absolute path. In my opinion, adding something like getcwd in the README usage example is not necessary and is a bit complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podcastinator podcastinator podcastinator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Landing page usage example is broken
2 participants
@chester-leung @podcastinator