fix: publicly re-export mzpeaks dependency to guarantee mz_read works.

[paretje]

When using the mz_read macro, at the moment you need to declare a dependency on mzpeaks for it to work. This can also result in issues due to version mismatches between the mzpeaks version used to build mzdata, and the version declared in your own project. pub use prevents this by making sure that the version used in the mz_read is the one used in mzdata, and avoids the need to make mzpeaks an additional dependency at all.

[mobiusklein]

Thank you for the PR. I am away right now and cannot do a proper review, but will be back at the end of the week. I think this is viable, but I need to see if I can reasonably adjust the API to prevent the symbol leakage. I'm being overly cautious here because I already re-export `mzpeaks::prelude` but it's riskier to do with concrete types so far as I can tell.

…

On Tue, Sep 17, 2024, 5:49 PM Kevin Velghe ***@***.***> wrote: When using the mz_read macro, at the moment you need to declare a dependency on mzpeaks for it to work. This can also result in issues due to version mismatches between the mzpeaks version used to build mzdata, and the version declared in your own project. pub use prevents this by making sure that the version used in the mz_read is the one used in mzdata, and avoids the need to make mzpeaks an additional dependency at all. ------------------------------ You can view, comment on, or merge this pull request online at: #9 Commit Summary - cf7780a <cf7780a> add pub use mzpeaks File Changes (2 files <https://github.com/mobiusklein/mzdata/pull/9/files>) - *M* src/io/shorthand.rs <https://github.com/mobiusklein/mzdata/pull/9/files#diff-f25066c375b998e19f7a539ee0cb91f3aed8dedabe6e01961a4dc4ea5495fbf8> (4) - *M* src/lib.rs <https://github.com/mobiusklein/mzdata/pull/9/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759> (4) Patch Links: - https://github.com/mobiusklein/mzdata/pull/9.patch - https://github.com/mobiusklein/mzdata/pull/9.diff — Reply to this email directly, view it on GitHub <#9>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAK4E6IZOICRRCQHKGZUBXDZXBMSBAVCNFSM6AAAAABOL4NHKWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTCNRSGY3TOMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mobiusklein]

I was unable to come up with a satisfactory alternative that doesn't simply lead to converting mzdata into an umbrella library with building block type libraries like mzpeaks becoming "features" you enable, similar to the noodles library for genomics data access. I think I'll have to go there eventually, but I'm not ready to do that just yet.