Add ability to watch for new trucks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This acts similar to the existing question, instead if "watch" is present then it will find the provided twitter handle and either save it or notify the user that we already are keeping an eye on it.
cpjolicoeur
requested changes
Apr 13, 2018
|
|
||
| if Regex.run ~r/<@#{slack.me.id}>:?\s+.*watch.*/, message.text do | ||
| twitter_regex = ~r/(?<=^|(?<=[^a-zA-Z0-9-_\.]))@([A-Za-z]+[A-Za-z0-9]+)/ | ||
| truck_handle = Regex.scan(twitter_regex, message.text) |> List.last |> List.first |
There was a problem hiding this comment.
Since we only seem to care about the first match here, it might make sense to use run/3 instead of scan/3 here. Will keep us from doing the (somewhat) wonky |> List.last |> List.first at the end.
There was a problem hiding this comment.
Also, we don't seem to be handling nil results in the scan here. We just pass it along to Trucks.watch/3, but I dont see a pattern there either that cases nil inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.