Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve dependency conflicts #37

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

wellwelwel
Copy link
Contributor

Sorry for the unsolicited PR. Please, feel free to close as well.

This PR follows exactly the same purpose of sidorares/node-mysql2#2988.

Small chores

  • I noticed that package.json and package-lock.json weren't synchronized, I just adjusted that.
  • Same idea for test script to use Node.js test runner.

Cache

This dependency change prevents conflicts for multiple major versions of the same package for the final user.

Also, it's interesting to note that even upgrading lru-cache to the same version for both named-placeholders and mysql2, this would still imply a premature breaking change in order to an outdated version of the lru-cache (8.x instead of 11.x).

To use the latest lru-cache, it requires Node.js v20.x.x or higher.


Note

This PR doesn't depend on sidorares/node-mysql2#2988 and vice versa. Each PR acts individually.

@wellwelwel
Copy link
Contributor Author

wellwelwel commented Sep 10, 2024

@sidorares, to fix the release-please error:

✖ Error when creating branch
Error: release-please failed: Error creating Pull Request: Resource not accessible by integration

Go to:

Settings > Actions > General > Workflow permissions

Then, check this option 🙋🏻‍♂️

Screenshot 2024-04-26 at 01 22 45

@wellwelwel wellwelwel marked this pull request as ready for review September 10, 2024 15:58
@sidorares sidorares merged commit bbaa20a into mysqljs:master Sep 18, 2024
2 checks passed
@wellwelwel wellwelwel deleted the cache branch September 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants