Set pipefail for Cram tests #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/cram-shell-pipefail
branch
from
8d27d76
to
7bf664b
Compare
victorlin
changed the base branch from
master
to
victorlin/cram-shared-setup
victorlin
force-pushed
the
victorlin/cram-shell-pipefail
branch
from
7bf664b
to
56e7657
Compare
genehack
approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
How's #1639? |
This was added in places where it's been necessary. Setting it in shared setup scripts simplifies tests and allows future tests to use pipes without the need to set pipefail explicitly. A couple calls with non-zero exit codes have been exposed. These still fall under expected behavior.
victorlin
force-pushed
the
victorlin/cram-shell-pipefail
branch
from
56e7657
to
8cac61c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This was added in places where it's been necessary. Setting it globally simplifies tests and allows future tests to use pipes without the need to set pipefail explicitly.
Related issue(s)
Checklist