Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 添加 websockets 驱动器 proxy 连接警告 #2916

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

shoucandanghehe
Copy link
Contributor

@shoucandanghehe shoucandanghehe commented Aug 21, 2024

related #2908

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.17%. Comparing base (6c1d7ad) to head (0bc66ba).
Report is 1 commits behind head on master.

Files Patch % Lines
nonebot/drivers/websockets.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2916      +/-   ##
==========================================
- Coverage   94.19%   94.17%   -0.03%     
==========================================
  Files          48       48              
  Lines        4051     4053       +2     
==========================================
+ Hits         3816     3817       +1     
- Misses        235      236       +1     
Flag Coverage Δ
unittests 94.17% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

🚀 Deployed to https://deploy-preview-2916--nonebot2.netlify.app

@yanyongyu yanyongyu linked an issue Aug 21, 2024 that may be closed by this pull request
@yanyongyu yanyongyu changed the title ✨ 在试图使用 websockets 驱动器通过 proxy 连接 ws 时抛出警告 Feature: 添加 websockets 驱动器 proxy 连接警告 Aug 21, 2024
@yanyongyu yanyongyu added the enhancement New feature or request label Aug 21, 2024
shoucandanghehe and others added 2 commits August 22, 2024 00:10
Co-authored-by: Ju4tCode <42488585+yanyongyu@users.noreply.github.com>
@yanyongyu yanyongyu merged commit cce13f6 into nonebot:master Aug 22, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Feature: 使 websockets 支持 proxy
2 participants