Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix manifestwork and appliedmanifestwork unsync issue #636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qiujian16
Copy link
Member

merge the two controller as reconcilers for one controller

Summary

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

/hold

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 70.30568% with 68 lines in your changes missing coverage. Please review.

Project coverage is 64.06%. Comparing base (e683e8c) to head (e2763fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lers/manifestcontroller/manifestwork_reconciler.go 75.43% 20 Missing and 8 partials ⚠️
...nifestcontroller/appliedmanifestwork_reconciler.go 64.38% 20 Missing and 6 partials ⚠️
...lers/manifestcontroller/manifestwork_controller.go 57.57% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   63.90%   64.06%   +0.16%     
==========================================
  Files         180      182       +2     
  Lines       14116    14105      -11     
==========================================
+ Hits         9021     9037      +16     
+ Misses       4192     4171      -21     
+ Partials      903      897       -6     
Flag Coverage Δ
unit 64.06% <70.30%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

merge the two controller as reconcilers for one controller

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant