Fix bug where buffers are not initialised. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The STM32F0xx uses one IRQ from both sending and receiving CAN packets. The HAL drivers use the same handler for both sending and receiving as well so it's enough to #define CAN1_RX0_IRQHandler. |
Closed
|
Thanks for this. I know this library has had bug somewhere causing reliability issues and just lately it has been pointing towards issue in the buffers. So it's probably this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the buffers are not initialized as null pointers
isInitialized()returns true andinitializeBuffers()exits early. This means that the buffers are never allocated on the heap.