Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update Storycap commands for Storybook v7 #822

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NaokiHaba
Copy link

@NaokiHaba NaokiHaba commented Nov 16, 2023

What does this change?

The name was changed from start-storybook to storybook-dev starting with storybook v7.
https://storybook.js.org/docs/react/api/cli-options

I have spent a lot of time on CI/CD retrofits due to this change.

This change will help users of storybook v7.

Thank you for your cooperation. @hond0413

We need your opinions! Please feel free to comment here. Thank you 🙇

References

> storycap --serverTimeout 60000 --captureTimeout 10000 --serverCmd 'start-storybook -p 6006' http://localhost:6006

info Wait for connecting storybook server http://localhost:6006.
error Timed out waiting for: http-get://localhost:6006
Error: Timed out waiting for: http-get://localhost:6006

fix result

> app@1.0.0 screenshot /
> storycap --serverTimeout 60000 --captureTimeout 10000 --serverCmd 'storybook dev -p 6006' http://localhost:6006

info Wait for connecting storybook server http://localhost:6006.
info Executable Chromium path: /usr/bin/google-chrome-stable
info Storycap runs with managed mode
info Found 3 stories.
info Screenshot was ended successfully in 22285 msec capturing 3 PNGs.

@NaokiHaba NaokiHaba changed the title feat: Update Storycap commands for Storybook v7 [Feature] Update Storycap commands for Storybook v7 Nov 16, 2023
@NaokiHaba NaokiHaba marked this pull request as ready for review November 16, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant