Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navfn path length threshold #1128

Open
wants to merge 2 commits into
base: noetic-devel
Choose a base branch
from

Conversation

DatSpace
Copy link

@DatSpace DatSpace commented Jun 7, 2021

This PR simply adds a new parameter for Navfn ROS, that allows you to limit the max allowed distance of the generated path.

Copy link
Member

@DLu DLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the overall goal here? I.e. What do you want to happen when the planned path is too long?

navfn/include/navfn/navfn_ros.h Outdated Show resolved Hide resolved
navfn/src/navfn_ros.cpp Outdated Show resolved Hide resolved
navfn/src/navfn_ros.cpp Outdated Show resolved Hide resolved
@DatSpace
Copy link
Author

The goal is to be able to avoid going all around in a path. For example if you have a room with a doughnut like shape and the path is blocked somewhere, I dont want the robot to pathfind all the way around to the other side of the blocked path.

By setting a limit to the path (optionally) we can avoid that very simply.

With the way it is implemented, navfn will throw a warning and then it will try to re plan until it times out. After that it will go into recovery as expected, which will clear any possible obstacles in the path etc, making it a very good way to do this, I believe.

@DatSpace DatSpace requested a review from DLu June 11, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants