-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[triton][tool] Add support for printing shared memory layouts in the triton-tensor-layout
tool
#4839
Merged
Merged
[triton][tool] Add support for printing shared memory layouts in the triton-tensor-layout
tool
#4839
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5c56056
Add support for printing shared memory layouts in the `triton-tensor-…
db996ed
clang format fixes
SamGinzburg beedbb0
Merge branch 'main' into PR-SharedLayoutPrinter
SamGinzburg 897ac07
remove export of helper functions
SamGinzburg eec3b89
fix clang format caused issues
SamGinzburg 6f55b4f
fix more clang format induced issues
SamGinzburg f5d61d7
Merge branch 'main' into PR-SharedLayoutPrinter
SamGinzburg e4e2960
Merge branch 'main' into PR-SharedLayoutPrinter
SamGinzburg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a deep understanding of linear layout, but from my superficial understanding, it can represent registers -> tensor element, or shared memory -> tensor element. This seems only print the layout from a shared memory perspective? How about the register one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only executed in the getSharedLayoutStr function, so it can only represent shared memory in this case; the registers perspective is at line 3353
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, just see your reply. Got it, thanks! The register view is for the distributed encoding thing