Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old formatters #686

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Replace old formatters #686

merged 4 commits into from
Oct 1, 2024

Conversation

Assem-Hafez
Copy link
Contributor

Summary

  • Remove old formatters and replace their usage with the new formatter

Changes

  • Remove old formatters along with their unit tests
  • add unit test for the new formatter
  • use the new formatter in the src/utils/data-formatters/format-workflow-history.ts
  • add more mocks

@Assem-Uber Assem-Uber merged commit 887646a into uber:release/4.0.0 Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tubignat tubignat tubignat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Assem-Hafez @tubignat @Assem-Uber