Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add area attribute to candidate graph nodes #21

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add area attribute to candidate graph nodes #21

merged 1 commit into from
Sep 16, 2024

Conversation

cmalinmayor
Copy link
Collaborator

Proposed Change

Add the area to the candidate graph nodes by default. Also adds an Area attribute to the NodeAttrs enum, and tests that the area scales with the scaled regionprops implementation.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (cdc12a4) to head (6ad4d55).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   86.88%   87.00%   +0.12%     
==========================================
  Files          14       14              
  Lines         427      431       +4     
==========================================
+ Hits          371      375       +4     
  Misses         56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AnniekStok AnniekStok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cmalinmayor cmalinmayor merged commit bf5c52b into main Sep 16, 2024
4 checks passed
@cmalinmayor cmalinmayor deleted the add_area branch September 16, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants